refactor(cubesql): Move all wrapper replacers params to separate enode #9105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Move all repacesr params from
WrapperPushdownReplacer
andWrapperPullupReplacer
to separate node variantWrapperReplacerContext
.Because of the way our current
plan_to_language!
works, for every non-recusive param in input enum it generates separate wrapper struct on Rust side. So, before this we had separateWrapperPushdownReplacerPushToCube
andWrapperPullupReplacerPushToCube
. And, because they are separate terminal variants, one can't just copy those in patterns, and had to do it in Rust code, like intransforming_rewrite
.This change allows:
wrapper_pushdown_replacer(cast_expr("?expr", "?data_type"), "?context")
=>cast_expr(wrapper_pushdown_replacer("?expr", "?context"), "?data_type")
All of this simplifies adding new parameters, and have measurable performance boost. On my laptop I measured from about 1 to 11% boost, depending on a benchmark. For example: